Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating NRRs against sent or received messages #220

Closed
beth-soptim opened this issue Feb 13, 2024 · 4 comments
Closed

Validating NRRs against sent or received messages #220

beth-soptim opened this issue Feb 13, 2024 · 4 comments
Assignees

Comments

@beth-soptim
Copy link
Contributor

It would be very useful if Phase4 would offer a functionality to validate an NRR against the sent message (full SOAP header, SOAP body, Payload).

@beth-soptim beth-soptim changed the title Validating received NRRs against sent messages Validating NRRs against sent messages Feb 13, 2024
@beth-soptim beth-soptim changed the title Validating NRRs against sent messages Validating NRRs against sent or received messages Feb 13, 2024
@phax phax self-assigned this Feb 13, 2024
@phax
Copy link
Owner

phax commented Feb 13, 2024

That sounds like a good plan. This check should contain

  • Verification of MessageId and RefToMessageId
  • Check that the SignalMessage is a Receipt with NRR
  • Check if the signature Reference elements from the source message are present in the NRR information of the receipt

phax added a commit that referenced this issue Aug 26, 2024
@phax
Copy link
Owner

phax commented Sep 23, 2024

@problemzebra2 better late than never, but it will be integrated in the next version of the 3.0.0 branch. Additional to the main checking logic, I added a IValidatingAS4SignalMsgConsumerResultHandler interface with which you can customize the activities needed on failure.

What is missing is passing the validation result handler through to all APIs - afterwards I will close this ticket.

@phax
Copy link
Owner

phax commented Nov 19, 2024

Shit - I missed that one for the 3.0.0 release - everything was nicely prepared, except for the setters in the builder :(
Btw. the final name is now IAS4SignalMessageValidationResultHandler for the respective interface.

phax added a commit that referenced this issue Nov 19, 2024
IAS4SignalMessageValidationResultHandler; #220
@phax
Copy link
Owner

phax commented Nov 19, 2024

Will be part of the upcoming 3.0.1 release.

Just add e.g. .signalMsgValidationResultHdl (new LoggingAS4SignalMsgValidationResultHandler ()) in your UserMessage or PullRequest builder

@phax phax closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants