Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FailOnError option? #57

Closed
rolfkleef opened this issue Nov 1, 2017 · 13 comments
Closed

FailOnError option? #57

rolfkleef opened this issue Nov 1, 2017 · 13 comments
Assignees
Milestone

Comments

@rolfkleef
Copy link
Contributor

I'm one of the Ant fans (still -- not had time to dive into Maven yet).

One thing that would help me: have a failOnError boolean attribute like the Ant XSLT task. Currently, it's possible to expect success or failure with expectSuccess, but I just want to process a collection of files regardless of the result of any single one.

@stefan-jung
Copy link

This is definitely a release blocker for org.doctales.schematron, thank you @rolfkleef for requesting this, I thought I already did this before.

phax added a commit that referenced this issue Nov 2, 2017
@phax phax added this to the v5.0.0 milestone Nov 2, 2017
@phax
Copy link
Owner

phax commented Nov 2, 2017

@phax phax closed this as completed Nov 2, 2017
@stefan-jung
Copy link

@fviolette
Copy link

@xephon2 Works on my end.
Does that cover #50 fully as well for you?

@stefan-jung
Copy link

stefan-jung commented Nov 2, 2017

Hey @fviolette, currently the build crashes because of a DITA-OT issue, that I've reported here. So I cannot say, If that covers #50 ATM.

@fviolette
Copy link

Oh that... :-)
Just running it via ANT looks fine, let's wait for some more debugging then.

@rolfkleef
Copy link
Contributor Author

Thanks for the speedy update! Unfortunately, it seems to break on my end: no output is produced in the new version.

I've put a small test in https://gist.github.com/rolfkleef/1c8224759e5cc240e956a97ea7cca92e with snapshots 41 and 42: if I change the classpath in the build.xml from version 41 to version 42, the schematron task does not produce output anymore.

ant schematron -d produces debug output that stops at:

...
Class java.lang.invoke.LambdaMetafactory loaded from parent loader (parentFirst)
Class java.util.function.Predicate loaded from parent loader (parentFirst)
[schematron] Schematron processing mode set to 'PURE'
[schematron] Using Schematron file '/home/rolf/dev/sandbox/ph-schematron-ant-task-test/rules.sch'

BUILD SUCCESSFUL
Total time: 0 seconds

Without the schematronProcessingEngine="pure" setting in the Ant task, it ends at the same point, with no output...

@phax phax reopened this Nov 2, 2017
phax added a commit that referenced this issue Nov 2, 2017
@phax
Copy link
Owner

phax commented Nov 2, 2017

Thanks for pointing this out. I wasn't capable of creating a reasonable "if" statement :( I used the files from your Gist as a test case. Any objections against incorporating this under Apache 2 license?

@rolfkleef
Copy link
Contributor Author

Great, works now with snapshot 44!

Maybe replace my own domain with example.com or so in the rules.sch file -- I've basically taken what's on your site under "Known issues", and started trying out which of the Schematron 2016 features are working (properties, role, see don't seem to end up in the SVRL output yet). No problem to include it.

@phax
Copy link
Owner

phax commented Nov 2, 2017

The problem was that if a SVRL directory was specified (and valid) the execution simply didn't start; URLs were fixed.

Schematron 2016 support is not really present, as I couldn't find any "change log" - any input???

@stefan-jung
Copy link

No, I only know the norm ISO/IEC 19757-3:2016

@rolfkleef
Copy link
Contributor Author

Same here. There is a bit of information on the new properties on http://schematron.com/an-overview-of-schematron/why-is-schematron-different/

I'm looking into what I really need, I'll open new issues for those.

@phax
Copy link
Owner

phax commented Nov 3, 2017

I think http://schematron.com/2016/11/iso-schematron-2016-released/ is a good starting point. I will close this issue and create a new one.

@phax phax closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants