Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add no-param "value" for annotation. #64

Closed
guiguilechat opened this issue Oct 19, 2018 · 3 comments
Closed

add no-param "value" for annotation. #64

guiguilechat opened this issue Oct 19, 2018 · 3 comments
Assignees

Comments

@guiguilechat
Copy link

Hello.

When I annotate eg a field with an annotation.
If this annotation accept one parameter which has name "value".
I can use this annotation with @annotation(myvalue)

In JCM I need to specify a name in the annotation. However, if I specify "value" it generates the correct expected result.
Could we have another function /** add a value to the default parameter of the annotation*/JAnnotationUse#param(String value){return param("value", value);}

I guess the issue is, that there are already many different methods for param(), eg with String, double, etc.

@phax phax self-assigned this Oct 20, 2018
@phax
Copy link
Owner

phax commented Oct 20, 2018

Sure no problem. I will create an overload for all types.

phax added a commit that referenced this issue Oct 20, 2018
`value` as the annotation parameter name (issue #64)
@phax
Copy link
Owner

phax commented Oct 20, 2018

Contained in 3.2.0

@phax phax closed this as completed Oct 20, 2018
@guiguilechat
Copy link
Author

you can close automatically the issue by using eg "fixed #64" in the comment of your commit.
I learnt that recently
https://help.github.com/articles/closing-issues-using-keywords/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants