Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BT-23 Mapping - CII Profile ID ignored in favor of hardcoded PEPPOL value #37

Closed
shenazz opened this issue Jan 15, 2025 · 2 comments
Closed

BT-23 Mapping - CII Profile ID ignored in favor of hardcoded PEPPOL value #37

shenazz opened this issue Jan 15, 2025 · 2 comments
Assignees
@phax
Labels
bug Something isn't working

Comments

@shenazz
Copy link

shenazz commented Jan 15, 2025

Current behavior:

In CII to UBL conversion, the source Profile ID: rsm:CrossIndustryInvoice/rsm:ExchangedDocumentContext/ram:BusinessProcessSpecifiedDocumentContextParameter/ram:ID
is ignored and instead, UBL's :
Invoice/cbc:ProfileID
is always set to:
urn:fdc:peppol.eu:2017:poacc:billing:01:1.0

Question:
Is this hardcoding of the PEPPOL profile ID the correct behavior, or should the original CII Profile ID value be preserved in the mapping?
@phax phax self-assigned this Jan 15, 2025
@phax phax added question Further information is requested bug Something isn't working and removed question Further information is requested labels Jan 15, 2025
phax added a commit that referenced this issue Jan 19, 2025
@phax
Taking the values of BT-23 and BT-24 from the source CII fields; #37
788f4ed
@phax
Copy link
Owner

phax commented Jan 19, 2025

@shenazz Thanks for bringing that to my attention. Of course the source value should be taken over.
However, setting the values per CLI remains, but the default value was removed.
This will be part of the 2.3.0 release.

@phax phax closed this as completed Jan 19, 2025
@shenazz
Copy link
Author

shenazz commented Jan 20, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phax phax

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phax @shenazz