Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeCode 381 should be converted to CreditNote #19

Closed
msccip opened this issue Mar 29, 2023 · 4 comments
Closed

TypeCode 381 should be converted to CreditNote #19

msccip opened this issue Mar 29, 2023 · 4 comments
Assignees
@phax
Labels
enhancement New feature or request question Further information is requested

Comments

@msccip
Copy link

msccip commented Mar 29, 2023

Hi,
the (Invoice)TypeCode 381 should be converted to ubl:CreditNote, not to ubl:Invoice.
@phax phax self-assigned this Mar 29, 2023
@phax phax added the question Further information is requested label Mar 29, 2023
@phax
Copy link
Owner

phax commented Mar 29, 2023

You are so true.
The target can be determined by a parameter.

  • When using the Java library version, please make sure setUBLCreationMode (EUBLCreationMode.AUTOMATIC) is used (which is the default)
  • When using the CLI version, you need to add the --mode AUTOMATIC parameter.

I assume you use the CLI version and I should use AUTOMATIC as the default....

@msccip
Copy link
Author

msccip commented Mar 30, 2023 •
edited
Loading

Ok, that works. Yes, I use the CLI Version. Is there a reason why it is not set as default ?

@phax
Copy link
Owner

phax commented Mar 30, 2023

I can't remember... Will make the necessary changes for the next release.

@phax phax added the enhancement New feature or request label Mar 30, 2023
phax added a commit that referenced this issue Mar 30, 2023
@phax
Using new default mode; #19
70b4855
@phax
Copy link
Owner

phax commented Mar 30, 2023

Is fixed in v2.0.2 that is just building.

@phax phax closed this as completed Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phax phax

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phax @msccip