-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mapping of AppliedTradeAllowanceCharge from NetPriceProductTradePrice instead of GrossPriceProductTradePrice #15
Comments
@cambid Thanks for pointing that out - good catch :) |
@phax Thanks for the response and the quick fix in 503c373. en16931-cii2ubl/en16931-cii2ubl/src/main/java/com/helger/en16931/cii2ubl/CIIToUBL23Converter.java Line 2145 in 503c373
|
You are so right - that happens when I work with too little focus :( |
@phax Please don't worry about the missing focus. 🧉☕ for more focus. Can you please build a new release 1.4.8 or 1.4.7-1? |
Release 1.4.8 is out - enjoy and thanks |
Thanks for the very great toolset to convert CII to UBL.
I think I've found a bug in the conversation.
According to the [mapping-cii-ubl.xlsx] in the docs-folder the AppliedTradeAllowanceCharge should be fetched from the GrossPriceProductTradePrice and not from the NetPriceProductTradePrice.
I've tested with the actual HEAD and a minimal example. In the attached files.zip there are three versions of the same invoice:
In the second version the allowance of 4.69 is missing completely.
files.zip
The text was updated successfully, but these errors were encountered: