Supporting all UNTDID 4461 codes; #34

README.md

@@ -94,6 +94,8 @@ CII to UBL Converter for EN 16931 invoices
 
 # News and noteworthy
 
+* v2.2.6 - 2024-12-23
+    * Supporting all values of the UNTDID 4461 code list. See [issue #34](https://github.com/phax/en16931-cii2ubl/pull/34) - thx @shenazz
 * v2.2.5 - 2024-10-22
     * Fixed the automatic module name. See [issue #32](https://github.com/phax/en16931-cii2ubl/pull/32) - thx @toherrmann
 * v2.2.4 - 2024-06-17

en16931-cii2ubl/src/main/java/com/helger/en16931/cii2ubl/AbstractCIIToUBLConverter.java

@@ -523,6 +523,11 @@ protected static boolean isPaymentMeansCodeDirectDebit (@Nullable final String s
 
   protected static boolean isPaymentMeansCodeOtherKnown (@Nullable final String s)
   {
+    // Allow all other codes of UNTDID 4461 (for BT-81)
+    // Based on issue #34
+    if (true)
+      return true;
+
     // 1 = Instrument not defined
     // 57 = Standing agreement
     // 68 = Online payment service

en16931-cii2ubl/src/test/java/com/helger/en16931/cii2ubl/MockSettings.java

@@ -50,7 +50,8 @@ final class MockSettings
                                                        "issue20.xml",
                                                        "issue22.xml",
                                                        "issue23.xml",
-                                                       "issue28.xml" };
+                                                       "issue28.xml",
+                                                       "issue34.xml" };
   private static final String [] TEST_FILES_XRECHNUNG = { "01.01_comprehensive_test_uncefact.xml" };
   private static final String [] TEST_FILES_XRECHNUNG_122 = { "01.01a-INVOICE_uncefact.xml",
                                                               "01.02a-INVOICE_uncefact.xml",