-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Chrome Version 56.0.2924.87 FullScreen Problem #27
Comments
Can confirm using |
HI, This is my example. It cannot on fullscreen module on mobile device by touch the screen. Thanks! |
Hi @AnnaHui , |
Hi @halilcakarr , This is Phaser example: It is not working on mobile, too. Thanks! |
Hi folks, I'm an engineer on Chrome and am seeing this problem as well. I filed this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=743315 It is not yet clear if this is a Chrome bug or not. I see that if I call game.scale.startFullScreen() from a regular onclick handler in a DOM element on the page (e.g., a button or a div) then it works. So it's possible that the input event that Phaser is capturing in game.input.onDown is not being recognized as a "user gesture" as required to allow a page to go full screen. |
Thanks for your assistance. One thing I've noticed is this also happens on phaser 2.6.2 (ie not phaser ce) on some of our devices, where previously it worked on the same phaser version. So I suspect it's a chrome regression, though can't be certain. |
From the issue: "This sounds like https://docs.google.com/document/d/1oF1T3O7_E4t1PYHV6gyCwHxOi3ystm0eSL5xZu7nvOg/edit#heading=h.qq59ev3u8fba, an intentional security tightening that shipped in M56. For any intervention, some developer pain is expected in order to force them to move to best practices, and since this has been in stable for 3 releases already, it seems this pain is tolerable and most developers have already adapted. So I'll tentatively close as working as intended." "It depends on the exact event they're triggering on. It looks like this JS is going fullscreen on "pointerdown". According to Rick's doc, that no longer works as of M56 -- I believe it should work if it changes to "pointerup" instead." From my tests using onTap for example seems to work, whereas I was using onDown before. Probably the example should be updated to not use onDown just to ensure compatibility with Android devices. |
@halilcakarr @lewispollard @AnnaHui Please see the conditions noted in Phaser.ScaleManager#startFullScreen and test again? https://phaser.io/examples/v2/display/fullscreen will likely fail on recent Chrome because it uses |
https://codepen.io/samme/pen/dzBZzm works for me, please reopen if you still see the problem. |
Actually, this is still a problem with chrome (68) on ios (11.4.1). @samme , Your demo above won't work and placing the "game.scale.startFullScreen()" into an onclick directly on a link on the page, still would refuse to go to fullscreen. Has anybody had the same issue? Can we reopen this issue? Or do you want a new issue for ios? |
@Weedshaker do you know if Chrome/iOS supports fullscreen at all? |
@samme, I can 100% assure, that it used to work with chrome/ios and safari/ios. since I used to test the game with those browsers less than a year ago. |
I'm not sure about this, we have never been able to use the fullscreen API on iOS as far as I know due to Apple's restrictions. Edit: see: https://caniuse.com/#search=fullscreen (iOS Safari includes iOS Chrome as they use the same engine under the hood) |
Look I maybe could be wrong, cause I haven't regularly tested the game on mobile. Though, I was pretty confident, that I used to play it in fullscreen. Still, if none of you guys has had that experience, I must be wrong, and I maybe did setup the page to hide any other elements obscuring the view, so that it looked like fullscreen. Anyways, code wise, as Phaser is using it, it looks correct by this standard & vendor prefixes: https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullScreen Sorry guys for steering up the pot. |
After realise phaser-ce v2.7.3 i try to use fullScreenAPI on Android Chrome and it doesn't work for me,
By the way, the same codes works for phaser 2.6.2. I change and test it.
Can you guys check for it :)
The text was updated successfully, but these errors were encountered: