-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a button "View on Github" when creating a PR #1044
Comments
Apparently, it will be hard to create a button in a growl morph (It is a subclass of TextMorph :'( ). We can still make it clickable. |
in theory, a TextMorph should allow that. but I wonder if we want that, since it would change the UI : until now, growl messages are just that: messages. can't we think in another solution? |
I was thinking about doing a "NotificationMorph" close to native notifications (you can embed images, buttons, icons, links...). But I gave up because I did not find a way to manage the layout of a morph that is not in a window :P |
Merged in #1047 . |
When a PR is created on github via the github plugin of Iceberg it would be great to have a "View on Github" button.
Most of the time I got check the PR after opening it.
In Pharo 7 it is possible to do that with a WebBrowser command. I don't know if it is possible to add a button in a Growl notification.
The text was updated successfully, but these errors were encountered: