Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Spec2 to 0.2.0 #5513

Merged
merged 12 commits into from
Jan 19, 2020
Merged

update Spec2 to 0.2.0 #5513

merged 12 commits into from
Jan 19, 2020

Conversation

estebanlm
Copy link
Member

@estebanlm estebanlm commented Jan 16, 2020 •
edited
Loading

update Spec2 to 0.2.0 and Commander2 to 2.1.0:

  • Add search capabilities to tables, lists and trees
  • Make SpComponentListPresenter behave as a list (actionable, selectable, searchable)
  • SpEditableList renamed to SpEditableListPresenter (and make it work)
  • Toggle buttons now can have icons (for some reason it was not allowing them before)
  • Radio buttons now accept an initial state of "none selected"
  • SpCodePresenter now have more actions defined.
  • Dialogs now can define a "default" button (which will be executed on meta+s)
  • Trait names renamed to match code conventions (prefix is SpT and not TSp)

@estebanlm estebanlm closed this Jan 16, 2020
@estebanlm estebanlm reopened this Jan 16, 2020
@Ducasse
Copy link
Member

Ducasse commented Jan 17, 2020

Hi esteban threre a re probems but mainly with dependencies and release tests

@estebanlm estebanlm closed this Jan 17, 2020
@estebanlm estebanlm reopened this Jan 17, 2020
@Ducasse
Copy link
Member

Ducasse commented Jan 18, 2020

We have
windows-32 / Tests-windows-32 / testChangeListInPresenterUpdatesWidget – Windows32.Spec2.Backend.Tests.SpTableCommonPropertiestTest and some setting persistent tests that are broken

@estebanlm
Copy link
Member Author

ok, I have a green test :)

@estebanlm estebanlm requested review from tesonep and jecisc January 19, 2020 11:11
@Ducasse Ducasse merged commit bbcdf97 into pharo-project:Pharo8.0 Jan 19, 2020
@MarcusDenker
Copy link
Member

This PR breaks the predebug window of the Debugger. It is used when executing

self notify: 'hi'

I will add an issue for that

@MarcusDenker MarcusDenker mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tesonep tesonep Awaiting requested review from tesonep

@jecisc jecisc Awaiting requested review from jecisc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estebanlm @Ducasse @MarcusDenker @tesonep