Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forked processes of TestResource from being terminated between TestCase methods being executed #3583

Merged
merged 3 commits into from
Jun 24, 2019
Merged

Fix forked processes of TestResource from being terminated between TestCase methods being executed #3583

merged 3 commits into from
Jun 24, 2019

Conversation

ErikOnBike
Copy link
Contributor

Fixes issue #3582

@welcome
Copy link

welcome bot commented Jun 19, 2019

Thanks for opening this pull request! Now continious integration (CI) will build Pharo with your change and runn all tests. This might fail due to many reasons! Please check if your PR breaks the build or makes tests fail. Feel free to add comments to the PR. After this, before your PR can be merged it needs one or more reviews. Do not hesitate to ask people (on the Mailinglist or Discord) to help! When the CI shows no problems and there are positive reviews, your PR will be merged.

@ErikOnBike
Copy link
Contributor Author

@dionisiydk could you please perform a review?

See also Issue on Pharo forum

@ErikOnBike
Copy link
Contributor Author

Error in CI does not seem related (I think ;-).

@ErikOnBike
Copy link
Contributor Author

There is something wrong with this PR. Some code ended up here that I did not change/touch explicitly. Will update later (today/tomorrow).

@ErikOnBike
Copy link
Contributor Author

Added another PR #3605 for Pharo7.0 branche (with same code/solution)

@MarcusDenker
Copy link
Member

ci failure not related

@MarcusDenker MarcusDenker mentioned this pull request Jun 24, 2019
Merged
MarcusDenker
MarcusDenker approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@MarcusDenker MarcusDenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@MarcusDenker MarcusDenker merged commit 04de409 into pharo-project:Pharo8.0 Jun 24, 2019
@welcome
Copy link

welcome bot commented Jun 24, 2019 •
edited by unfurl-links bot
Loading

Congrats on merging your first pull request! Do another one! We try to have a list of (relatively) easy issues here: https://github.com/orgs/pharo-project/projects/8.

GitHub
GitHub is where people build software. More than 36 million people use GitHub to discover, fork, and contribute to over 100 million projects.

@ErikOnBike ErikOnBike mentioned this pull request Jun 27, 2019
Closed
@ErikOnBike ErikOnBike deleted the 3582- branch June 28, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusDenker MarcusDenker MarcusDenker approved these changes

@dionisiydk dionisiydk dionisiydk approved these changes

Assignees
No one assigned
Labels
Status: Tests passed please review!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErikOnBike @MarcusDenker @dionisiydk