Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version in #iceberg for BaselineOfPharo for Pharo 11 to ‘v2.2.3’ #17644

Merged

Conversation

Rinzwind
Copy link
Contributor

This pull request updates the version in #iceberg for BaselineOfPharo for Pharo 11 to ‘v2.2.3’. Before this can be merged, a corresponding tag referring to commit 283403745e94a1d3 needs to be added.

@jecisc
Copy link
Member

jecisc commented Jan 21, 2025

https://github.com/pharo-vcs/iceberg/releases/tag/v2.2.3

GitHub
What's Changed

Make repair detached display the current branch by @bouraqadi in #1753
Revert "Make repair detached display the current branch" by @guillep in #1790
Backport multibyte commit messag...

@jecisc jecisc closed this Jan 21, 2025
@jecisc jecisc reopened this Jan 21, 2025
@jecisc jecisc merged commit d63208e into pharo-project:Pharo11 Jan 21, 2025
1 check failed
@astares
Copy link
Member

astares commented Jan 21, 2025

@jecisc Out of curiosity? Why in Pharo11 and not Pharo12 as a backport? If for both: where is the one for P12?

@jecisc
Copy link
Member

jecisc commented Jan 21, 2025

I think Rinzwind is working in P11 and so is pushing the bugfixes there.
We should also push them in P12. Just, that requires time :(

@Rinzwind
Copy link
Contributor Author

It’s a backport from Pharo 12, the fix in Iceberg pull request #1705 is dated a few weeks after Pharo 11’s release. While we’ve been loading an older patch of our own, I’ve occasionally had to modify the method when working in a base Pharo 11 image, so I thought I’d better just belatedly fix it for good. We’re considering upgrading to Pharo 12 but have hit issues with Monticello (#17586) and Metacello (#17645).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants