Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageNotUnderstood: EpFileLogNode>>content when attempting to apply changes in Epicea #4529

Closed
akgrant43 opened this issue Sep 9, 2019 · 6 comments · Fixed by #4538
Closed

Comments

@akgrant43
Copy link
Collaborator

Attempting to apply changes from a previous session in Epicea results in MessageNotUnderstood: EpFileLogNode>>content.

Steps to reproduce:

  1. Open Tools -> Code Changes
  2. Choose a previous session and a change (that can be applied).
  3. Click 'Apply...'
Image
-----
/dev/shm/p8/Pharo.image
Pharo8.0.0
Build information: Pharo-8.0.0+build.714.sha.16caf034e78b69bc8c14c83b7d5d9ee56bd02914 (64 Bit)
Unnamed

Virtual Machine
---------------
/dev/shm/p8/pharo-vm/lib/pharo
CoInterpreterWithQueueFFI VMMaker-CompatibleUserName.1567758211 uuid: 5f7b6801-ffba-5f78-9439-cb5ebb9e3ff8 Sep  6 2019
StackToRegisterMappingCogit * VMMaker-CompatibleUserName.1567758211 uuid: 5f7b6801-ffba-5f78-9439-cb5ebb9e3ff8 Sep  6 2019
d140609 - Commit: d140609 - Date: 2019-09-06 10:23:31 +0200

Pharo 8.1.0 built on Sep  6 2019 10:26:22 Compiler: 5.4.0 20160609
VMMaker versionString d140609 - Commit: d140609 - Date: 2019-09-06 10:23:31 +0200
CoInterpreterWithQueueFFI VMMaker-CompatibleUserName.1567758211 uuid: 5f7b6801-ffba-5f78-9439-cb5ebb9e3ff8 Sep  6 2019
StackToRegisterMappingCogit * VMMaker-CompatibleUserName.1567758211 uuid: 5f7b6801-ffba-5f78-9439-cb5ebb9e3ff8 Sep  6 2019
@akgrant43
Copy link
Collaborator Author

Stack:

EpFileLogNode(Object)>>doesNotUnderstand: #content
EpUnifiedBrowserPresenter>>refreshIfMonitorLogSelected
OmDeferrer>>sendMessage
[ self sendMessage ] in OmDeferrer>>flush in Block: [ self sendMessage ]
BlockClosure>>ensure:
OmDeferrer>>flush
[ "Loop until enough time passed since last #schedule"
[ DateAndTime now < (lastSchedule + duration) ]
	whileTrue: [ duration wait ].

"Execute deferred action (if not flushed before) and clean up"
self flush ] in OmDeferrer>>runMessageProcess in Block: [ "Loop until enough time passed since last #sched...etc...
[ self value.
Processor terminateActive ] in BlockClosure>>newProcess in Block: [ self value....

@akgrant43
Copy link
Collaborator Author

Removing #content message send in EpUnifiedBrowserPresenter>>refreshIfMonitorLogSelected appears to resolve the issue.

@jecisc
Copy link
Member

jecisc commented Sep 9, 2019

Hi,

I'll take a look as soon as I'll have time.

My guess is that it is caused by the migration to Spec 2. Probably a presenter was returning a wrapped entity somewhere while Spec 2 return the entity directly. (Is just a guess ;) )

jecisc added a commit to jecisc/pharo that referenced this issue Sep 9, 2019
@akgrant43
Copy link
Collaborator Author

Hi @jecisc ,

The commit you made looks correct, but there doesn't appear to be a PR associated with it.

Thanks,
Alistair

@MarcusDenker
Copy link
Member

I created a PR from the Github interface: #4538

@akgrant43
Copy link
Collaborator Author

Thanks @jecisc & @MarcusDenker !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants