Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AbsolutePath] withParents on root , on linux , return 2 root path #4258

Closed
CafeKrem opened this issue Aug 9, 2019 · 2 comments · Fixed by #4408
Closed

[AbsolutePath] withParents on root , on linux , return 2 root path #4258

CafeKrem opened this issue Aug 9, 2019 · 2 comments · Fixed by #4408

Comments

@CafeKrem
Copy link
Contributor

CafeKrem commented Aug 9, 2019

Linux
FileLocator root fullPath withParents
return:
{ Path root . Path root }
it's strange
@Ducasse
Copy link
Member

Ducasse commented Aug 9, 2019

This is the same on mac. but what should it returns. When you are on the root the parent is what?
BTW we should add a comment on the method.

@CafeKrem
Copy link
Contributor Author

CafeKrem commented Aug 9, 2019

I think he should return { Path root }
by definition, the root has no parent.

jecisc added a commit to jecisc/pharo that referenced this issue Aug 23, 2019
@jecisc
Fix bug in AbsolutePath>>#withParents returning two times Root in som…
903781c 
…e cases.

Fixes pharo-project#4258
@jecisc jecisc mentioned this issue Aug 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4258-AbsolutePath-withParents-on-root---on-linux---return-2-root-path jecisc/pharo
2 participants
@Ducasse @CafeKrem