Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement(versionning): Extract full semantic version from git #884

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Enhancement(versionning): Extract full semantic version from git #884

merged 2 commits into from
Dec 12, 2024

Conversation

guillep
Copy link
Member

@guillep guillep commented Dec 5, 2024 •
edited
Loading

Backport #870 to the stable branch

Extract Major.Minor.Patch-Suffix from git repository tags

Use https://github.com/nunofachada/cmake-git-semver as a base.

This

  • removes manual version numbering that needs to be maintained (and that we can mistake)
  • enables us to have suffix information such as ALPHA, SNAPSHOT or RC

PalumboN
PalumboN approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 👍

@guillep guillep merged commit eefa0c6 into pharo-10 Dec 12, 2024
0 of 2 checks passed
@guillep guillep deleted the versions10 branch December 12, 2024 12:55
@guillep guillep mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PalumboN PalumboN PalumboN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillep @PalumboN