Primitive to compare bytes #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re indexable objects byte by byte even if they are not indexable by bytes
|
@doste Almost everything seems ok for this to land! Tests show still two users of primitiveCompareBytes2. We should remove those tests before integration as the implementation does not exist anymore ^^. 
|
My bad. Now it's been removed :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #611
This pull request introduces a new primitive to compare bytes.
In the mentioned PR, two implementations were proposed, one using a loop in 'pure Pharo' and the other memcmp and thus relying on the C implementation.
We made a couple of benchmarks and we saw that the memcmp implementation:
- is 3x faster than doing it directly in Pharo when the compared bytes are few.
- is hundreds of times faster when comparing thousands of bytes.
The alternative word-by-word comparison implemented purely in slang is also better than the baseline but it is 10x slower than memcmp for large comparisons.