Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ephemeron scanning perf #691

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

guillep
Copy link
Member

@guillep guillep commented Sep 13, 2023

This PR fixes an issue when scanning ephemerons during full GC.
The issue caused ephemerons discovered during scanning to not be fired (if needed) in the same GC, needing multiple GCs to fire all the firable ephemerons in the list.

This PR fixes the tracing so that new ephemerons are scanned in the same loop.

@guillep guillep changed the base branch from pharo-10 to pharo-12 September 13, 2023 09:45
@guillep guillep force-pushed the fix/ephemeronscanningperf branch from fa21c5e to edfb4ed Compare September 13, 2023 10:17
@guillep guillep force-pushed the fix/ephemeronscanningperf branch from edfb4ed to 27556c3 Compare September 13, 2023 12:07
@guillep guillep changed the base branch from pharo-12 to pharo-10 September 13, 2023 12:08
@guillep
Copy link
Member Author

guillep commented Sep 13, 2023

CI is green

@guillep guillep merged commit 2d96a1b into pharo-project:pharo-10 Sep 13, 2023
@guillep guillep deleted the fix/ephemeronscanningperf branch September 13, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant