Fix and test for inlinings with If's and right shift not translated #667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a C code generator test and fix which involves inlinings with an if expression in the left side of a right shift operation. For example, Slang code like:
was causing any translation which uses a similar pattern to fail, because the CIfStatementNode was asserted to be an expression. In the fix (thanks to Guille), we pass a CTernaryNode representing the if instead to correctly generates the C code.