Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo "Make instantiateClass more robust when the format is missing" #632

Closed

Conversation

guillep
Copy link
Member

@guillep guillep commented Jun 29, 2023

Redo #629

@privat

@privat
Copy link
Contributor

privat commented Jun 29, 2023

I'm trying to understand what is the issue with the PR.

build/dist/pharo --logLevel=4 Pharo.image eval '4+4' does not works an seem locked in some loop

[DEBUG] 2023-06-29 15:42:17.000 sqAllocateMemory (src/memoryUnix.c:179):Loading the image in 0x10008831000
[DEBUG] 2023-06-29 15:42:21.000 sqAllocateMemory (src/memoryUnix.c:130):Requested Size 16777216
[DEBUG] 2023-06-29 15:42:21.000 sqAllocateMemory (src/memoryUnix.c:139):Aligned Requested Size 16777216
[DEBUG] 2023-06-29 15:42:21.000 sqAllocateMemory (src/memoryUnix.c:141):Trying to load the image in 0x10009831000
[DEBUG] 2023-06-29 15:42:21.000 sqAllocateMemory (src/memoryUnix.c:179):Loading the image in 0x10009831000
[DEBUG] 2023-06-29 15:42:29.000 sqAllocateMemory (src/memoryUnix.c:130):Requested Size 16777216
[DEBUG] 2023-06-29 15:42:29.000 sqAllocateMemory (src/memoryUnix.c:139):Aligned Requested Size 16777216
[DEBUG] 2023-06-29 15:42:29.000 sqAllocateMemory (src/memoryUnix.c:141):Trying to load the image in 0x1000a831000
[DEBUG] 2023-06-29 15:42:29.000 sqAllocateMemory (src/memoryUnix.c:179):Loading the image in 0x1000a831000

According to git bisect, the issue is in the last commit a9336aa but I have no real idea yet of what is the problem

@guillep
Copy link
Member Author

guillep commented Jun 29, 2023

my take: 0 is a valid format, and nil is translated as NULL, where NULL == 0

@guillep
Copy link
Member Author

guillep commented Jun 30, 2023

Closing in favor of #634

@guillep guillep closed this Jun 30, 2023
@guillep guillep deleted the revert-631-revert-629-instantiateclass-primitivefail branch August 9, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants