Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added comments and renamed methods during todays dojo #623

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Added comments and renamed methods during todays dojo #623

merged 2 commits into from
Jun 21, 2023

Conversation

Mathilde411
Copy link

@jordanmontt
Copy link
Member

There are more changes that the ones that we did. Are those related?

@PalumboN PalumboN added the dojo Things developed on VM Dojos label Jun 20, 2023
@Mathilde411
Copy link
Author

Mathilde411 commented Jun 20, 2023 •
edited
Loading

Yup that's my fault I selected the wrong branch to merge in, it should have been pharo-12

@PalumboN PalumboN changed the base branch from pharo-10 to pharo-12 June 20, 2023 17:11
@PalumboN
Copy link
Collaborator

Changed ;)

@guillep
Copy link
Member

guillep commented Jun 21, 2023

Thanks everybody, thanks @BastouP411 !

@guillep guillep merged commit ac54bfa into pharo-project:pharo-12 Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep guillep approved these changes

@jordanmontt jordanmontt jordanmontt approved these changes

Assignees
No one assigned
Labels
dojo Things developed on VM Dojos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mathilde411 @jordanmontt @PalumboN @guillep