Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Pharo VM dependency graph #554

Merged
merged 7 commits into from
Mar 20, 2023

Conversation

hernanmd
Copy link
Member

This PR makes cmake to generate a GraphViz PNG with the VM dependency graph, in the build directory.
Add the option BUILD_WITH_GRAPHVIZ (default set to TRUE) in CMakeLists.txt
Handle the case of dot not present in the target system (find_program(DOT dot)...)

@hernanmd hernanmd added enhancement New feature or request build-system labels Mar 15, 2023
@hernanmd hernanmd self-assigned this Mar 15, 2023
@hernanmd hernanmd requested a review from guillep March 15, 2023 17:01
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
cmake/CMakeGraphVizOptions.cmake Outdated Show resolved Hide resolved
@hernanmd hernanmd requested a review from guillep March 16, 2023 15:55
Copy link
Member Author

@hernanmd hernanmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and applied requested changes.

Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I'll remove a line over there and merge!

CMakeLists.txt Outdated Show resolved Hide resolved
@guillep guillep merged commit 83890d2 into pharo-project:pharo-10 Mar 20, 2023
@guillep
Copy link
Member

guillep commented Mar 20, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-system enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants