Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slang: Integer>>#bitOr: and Integer>>#| are translated to C code differently #523

Merged
merged 5 commits into from
Mar 20, 2023
Merged

Slang: Integer>>#bitOr: and Integer>>#| are translated to C code differently #523

merged 5 commits into from
Mar 20, 2023

Conversation

hernanmd
Copy link
Member

@hernanmd hernanmd commented Dec 14, 2022 •
edited
Loading

Fix #446

@hernanmd hernanmd requested a review from guillep December 14, 2022 15:14
@tesonep tesonep changed the base branch from pharoX to pharo-10 December 16, 2022 09:26
@guillep guillep changed the title Fix 446 Slang: Integer>>#bitOr: and Integer>>#| are translated to C code differently Dec 19, 2022
@tesonep
Copy link
Collaborator

tesonep commented Jan 3, 2023

@hernanmd There are changes in files that are not related with the issue: the cmake files. Are they part of another PR?

@hernanmd
Copy link
Member Author

hernanmd commented Jan 3, 2023

During the VM Dojo we had problems compiling the VM because SDL2 wasn't build since it was installed in a different location. So we add DEPENDENCIES_FORCE_BUILD option. Let me know if I should open a new issue.

@guillep
Copy link
Member

guillep commented Jan 3, 2023

During the VM Dojo we had problems compiling the VM because SDL2 wasn't build since it was installed in a different location. So we add DEPENDENCIES_FORCE_BUILD option. Let me know if I should open a new issue.

Yes, but that is already in #522, we should rebase this branch and remove the extra commit maybe.

@privat
Copy link
Contributor

privat commented Jan 18, 2023

What a menial task! Good job!

@hernanmd
Copy link
Member Author

hernanmd commented Feb 23, 2023 •
edited by unfurl-links bot
Loading

During the VM Dojo we had problems compiling the VM because SDL2 wasn't build since it was installed in a different location. So we add DEPENDENCIES_FORCE_BUILD option. Let me know if I should open a new issue.

Yes, but that is already in #522, we should rebase this branch and remove the extra commit maybe.

I merged the changes and now the included commits are only related to this issue: https://github.com/pharo-project/pharo-vm/pull/523/files

GitHub
Fix #446

guillep
guillep approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
I restarted the CI

@guillep
Copy link
Member

guillep commented Mar 20, 2023

CI was good!!!

@guillep guillep merged commit 809b6e0 into pharo-project:pharo-10 Mar 20, 2023
@guillep guillep mentioned this pull request Aug 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep guillep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slang: Integer>>#bitOr: and Integer>>#| are translated to C code differently
4 participants
@hernanmd @tesonep @guillep @privat