Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Update ADVS vignette #28

Closed
Siddhesh2097 opened this issue Sep 13, 2024 · 3 comments · Fixed by #46
Closed

Documentation: Update ADVS vignette #28

Siddhesh2097 opened this issue Sep 13, 2024 · 3 comments · Fixed by #46
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Siddhesh2097
Copy link
Contributor

Siddhesh2097 commented Sep 13, 2024

Background Information

Several updates are needed to the ADVS vignette. This includes:

  • Use new {admiral} AVALCAT derivation function.
    • Currently there is nothing specific in {admiral} for AVALCAT derivation so ADVS template and vignette just go about it using tidyverse tools. This will change once the functionality is added to {admiral} - see here. Update: This is now added to Admiral dev version and can be completed.
  • Use restrict_derivation() in conjunction with derive_vars_crit_flag().
    • Without using restrict_derivation the crit flag is present on all PARAMCD's. See ADVS template for how to implement.
  • Update PARACAT1 to "Anthropometric measurements" for PARAMN in range 1-5. This would also close Documentation: Update ADVS metabolic vignette lookup table PARCAT1 #32

Definition of Done

Update vignette as per specification defined above.

@Siddhesh2097 Siddhesh2097 changed the title Update ADVS vignette, template to use new {admiral} AVALCAT derivation function #24 Update ADVS vignette, template to use new {admiral} AVALCAT derivation function Sep 13, 2024
@Siddhesh2097 Siddhesh2097 self-assigned this Sep 13, 2024
@manciniedoardo
Copy link
Collaborator

Hi @Siddhesh2097, how is this going?

@AndersAskeland
Copy link
Member

I am changing this issue to include all required ADVS updates.

@AndersAskeland AndersAskeland changed the title Update ADVS vignette, template to use new {admiral} AVALCAT derivation function Update ADVS vignette Oct 23, 2024
@manciniedoardo manciniedoardo added the documentation Improvements or additions to documentation label Oct 23, 2024
@AndersAskeland AndersAskeland changed the title Update ADVS vignette Documentation: Update ADVS vignette Oct 23, 2024
@Siddhesh2097
Copy link
Contributor Author

Siddhesh2097 commented Oct 25, 2024

My apologies @manciniedoardo , I completely lost track of this issue. Will start working on this.

Siddhesh2097 pushed a commit that referenced this issue Oct 26, 2024
Siddhesh2097 pushed a commit that referenced this issue Oct 26, 2024
…r update to parcat1 of BMI at a later section.
Siddhesh2097 pushed a commit that referenced this issue Oct 26, 2024
@Siddhesh2097 Siddhesh2097 linked a pull request Oct 26, 2024 that will close this issue
14 tasks
Siddhesh2097 pushed a commit that referenced this issue Oct 29, 2024
Siddhesh2097 pushed a commit that referenced this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants