Closes #468 multiple units: extend required_unit argument in assert_unit()

[bundfussr]

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
• Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• Address any updates needed for vignettes and/or templates
• Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
• Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• Address or fix all lintr warnings and errors - lintr::lint_package()
• Run R CMD check locally and address all errors and warnings - devtools::check()
• Link the issue in the Development Section on the right hand side.
• Address all merge conflicts and resolve appropriately
• Pat yourself on the back for a job well done! Much love to your accomplishment!

[github-actions]

Package	Line Rate	Health
admiraldev	97%	✔
Summary	97% (1063 / 1097)	✔

[bundfussr]

@bundfussr

library(tibble)

advs <- tribble(
  ~USUBJID,      ~PARAMCD,  ~PARAM,               ~AVAL, ~AVALU,        ~VISIT,
  "01-101-1001", "TEST",    "Unitless Parameter", 1,     NA_character_, "SCREENING",
  "01-101-1001", "TEST",    "Unitless Parameter", 2,     NA_character_, "WEEK 2",
  "01-101-1001", "TEST",    "Unitless Parameter", 3,     NA_character_, "WEEK 3"
)

assert_unit(
  advs,
  param = "TEST",
  get_unit_expr = AVALU
)

gives the following:

Error:
! Multiple units found for "TEST". Please review and update the units.
Run `rlang::last_trace()` to see where the error occurred.

Good catch!
I've fixed it.

[yurovska]

Great job @bundfussr! No other comments from my end.

[manciniedoardo]

Minor suggestion in NEWS.md but looks good otherwise.

[manciniedoardo]

Suggested change

	possible to specify more than one unit or not specifying it. In the latter case
	possible to specify more than one unit or not specify it at all. In the latter case

[bundfussr]

Updated

[bms63]

@bundfussr I have nothing to add. Feel free to merge after considering the suggestions. Looks a few are still outstanding. Many thanks for pushing this through so quickly and @yurovska for great review!!

[yurovska]

@bundfussr I have nothing to add. Feel free to merge after considering the suggestions. Looks a few are still outstanding. Many thanks for pushing this through so quickly and @yurovska for great review!!

I’m unfortunately not able to resolve conversations as I don’t have corresponding button (likely don’t have permission), but I’m happy with all updates made. @bundfussr Please feel free to close them all.