Closes #2521 remove lifecycle deprecation code for get summary records

NEWS.md

@@ -39,6 +39,8 @@ or that the queries dataset contains duplicates. (#2543)
 
 - test scripts, R, and markdown files for `create_single_dose_dataset` and `occds.Rmd` updated to include a `STUDYID` column because of `get_admiral_option("subject_keys")` update above. (#2501)
 
+- In `get_summary_records()`, previously deprecated formal arguments `analysis_var` and `summary_fun` now removed from function, documentation, tests etc. (#2521)
+
 ## Breaking Changes
 
 - The following function arguments are entering the next phase of the deprecation process: (#2487)

R/derive_param_exposure.R

@@ -54,11 +54,11 @@
 #' an observation is added to the output dataset and the defined values are set to the defined
 #' variables
 #'
-#' @return The input dataset with a new record added for each group (with respect to the variables
-#' specified for the `by_vars` parameter). That is, a variable will only
+#' @return The input dataset with a new record added for each group (as defined
+#' by `by_vars` parameter). That is, a variable will only
 #' be populated in this new record if it is specified in `by_vars`.
 #' For each new record,
-#' + the variable specified `analysis_var` is computed as defined by `summary_fun`,
+#' + `set_values_to` lists each specified variable and computes its value,
 #' + the variable(s) specified on the LHS of `set_values_to` are set to their paired value (RHS).
 #' In addition, the start and end date are computed as the minimum/maximum dates by `by_vars`.
 #'

R/get_summary_records.R

@@ -18,7 +18,7 @@
 #' see the `derive_summary_records()` function.
 #'
 #' @param dataset
-#' `r roxygen_param_dataset(expected_vars = c("by_vars", "analysis_var"))`
+#' `r roxygen_param_dataset(expected_vars = c("by_vars"))`
 #'
 #' @param by_vars Grouping variables
 #'
@@ -38,18 +38,6 @@
 #'   + `filter_rows = (dplyr::n() > 2)` will filter n count of `by_vars` greater
 #'   than 2.
 #'
-#' @param analysis_var Analysis variable.
-#'
-#'  `r lifecycle::badge("deprecated")` Please use `set_values_to` instead.
-#'
-#' @param summary_fun Function that takes as an input the `analysis_var` and
-#'   performs the calculation.
-#'
-#'  `r lifecycle::badge("deprecated")` Please use `set_values_to` instead.
-#'
-#'   This can include built-in functions as well as user defined functions,
-#'   for example `mean` or `function(x) mean(x, na.rm = TRUE)`.
-#'
 #' @param set_values_to Variables to be set
 #'
 #'   The specified variables are set to the specified values for the new
@@ -160,8 +148,6 @@
 get_summary_records <- function(dataset,
                                 by_vars,
                                 filter = NULL,
-                                analysis_var,
-                                summary_fun,
                                 set_values_to = NULL) {
   assert_vars(by_vars)
   filter <- assert_filter_cond(enexpr(filter), optional = TRUE)
@@ -171,16 +157,6 @@ get_summary_records <- function(dataset,
     check_is_grouped = FALSE
   )
   assert_varval_list(set_values_to)
-  if (!missing(analysis_var) || !missing(summary_fun)) {
-    deprecate_stop(
-      "1.1.0",
-      I("get_summary_records(anaylsis_var = , summary_fun = )"),
-      "get_summary_records(set_values_to = )"
-    )
-    analysis_var <- assert_symbol(enexpr(analysis_var))
-    assert_s3_class(summary_fun, "function")
-    set_values_to <- exprs(!!analysis_var := {{ summary_fun }}(!!analysis_var), !!!set_values_to)
-  }
 
   # Summarise the analysis value
   dataset %>%