-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1839 dummy function created #2538
Conversation
…into 1839_dummy_sg
Hi @kiwi5104679 - as discussed by email, you noted that your pkgbuild is failing: |
Hi @manciniedoardo , @AndersAskeland Could you take a look again? |
Hi @AndersAskeland , @manciniedoardo I could run pkgdown::build_site() and devtools::check()!! I checked examples are displayed correctly and a new function occurs. Have you seen such a situation? |
Probably fine for all intents and purposes in this exercise - well done! |
@kiwi5104679 The When you have non-standard files, one way to avoid this "note" would be to define them in your However, as @manciniedoardo said, for the extent of this exercise it does not matter. Everything else looks good, so I am going to close this pull-request - Great work! Looking forward to seeing your contributions on admiralmetabolic :) |
@AndersAskeland , @manciniedoardo |
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.md
for tracking developer-facing issues.pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()