Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1839 dummy function created #2538

Closed
wants to merge 16 commits into from
Closed

Closes #1839 dummy function created #2538

wants to merge 16 commits into from

Conversation

kiwi5104679
Copy link

@kiwi5104679 kiwi5104679 commented Oct 21, 2024

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes DUMMY ISSUE FOR ONBOARDING #1839 into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@kiwi5104679 kiwi5104679 added the onboarding Bringing in the masses! label Oct 21, 2024
Copy link

github-actions bot commented Oct 21, 2024

Code Coverage

Package Line Rate Health
admiral 97%
Summary 97% (4940 / 5102)

@manciniedoardo
Copy link
Collaborator

manciniedoardo commented Oct 21, 2024

Hi @kiwi5104679 - as discussed by email, you noted that your pkgbuild is failing:
image
I suggest setting @leywords and @family to an already existing category, e.g. @ other_advanced. Try see if that fixes your CMD check as well.

@kiwi5104679
Copy link
Author

Hi @manciniedoardo , @AndersAskeland
I corrected @Keyword and @family to other_advanced and updated documents.
But I could not executed pkgdown::build_site() and devtools::check().
I found what is wrong, but I just can't do it.......

Could you take a look again?

@kiwi5104679
Copy link
Author

kiwi5104679 commented Oct 25, 2024

Hi @AndersAskeland , @manciniedoardo

I could run pkgdown::build_site() and devtools::check()!!
The problem seemed to be caused by my environment of Rstudio.

image

I checked examples are displayed correctly and a new function occurs.
But the appearance of the page is a little different from actual site.

image

Have you seen such a situation?

@manciniedoardo
Copy link
Collaborator

Hi @AndersAskeland , @manciniedoardo

I could run pkgdown::build_site() and devtools::check()!! The problem seemed to be caused by my environment of Rstudio.

image

I checked examples are displayed correctly and a new function occurs. But the appearance of the page is a little different from actual site.

image

Have you seen such a situation?

Probably fine for all intents and purposes in this exercise - well done!

@AndersAskeland
Copy link
Member

@kiwi5104679 The Note you are seeing is due to you having some top-level (data-backup) files that are not "supported". Actually, the only files allowed by default are defined here.

When you have non-standard files, one way to avoid this "note" would be to define them in your .Rbuildignore.

However, as @manciniedoardo said, for the extent of this exercise it does not matter. Everything else looks good, so I am going to close this pull-request - Great work! Looking forward to seeing your contributions on admiralmetabolic :)

@kiwi5104679
Copy link
Author

@AndersAskeland , @manciniedoardo
Thank you for checking. Got it.
Thanks to your supports, I managed to close this issue.
I may ask for support on a non-dummy issue, but thanks in advance!

@bms63 bms63 deleted the 1839_dummy_sg branch December 2, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Bringing in the masses!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DUMMY ISSUE FOR ONBOARDING
3 participants