Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2146 Fix Time Imputation Flag #2195

Merged
merged 12 commits into from
Nov 6, 2023
Merged

Closes #2146 Fix Time Imputation Flag #2195

merged 12 commits into from
Nov 6, 2023

Conversation

ahasoplakus
Copy link
Collaborator

@ahasoplakus ahasoplakus commented Oct 26, 2023

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@ahasoplakus ahasoplakus self-assigned this Oct 26, 2023
@ahasoplakus ahasoplakus linked an issue Oct 26, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Code Coverage

Package Line Rate Health
admiral 98%
Summary 98% (4403 / 4477)

Copy link
Collaborator

@zdz2101 zdz2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, mostly just small stuff remiaing: modify DESCRIPTION to account for purrr 1.0.0 features, and make an entry for NEWS/changelog and this looks almost ready to go!

R/derive_date_vars.R Show resolved Hide resolved
R/derive_date_vars.R Show resolved Hide resolved
for (c in c("hour", "minute", "second")) {
hms <- c("hour", "minute", "second")
time_part <-
map(set_names(hms), \(y) map_dbl(dtm, \(x) exec(y, x)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this! It is really clever but certainly has a different look and flavor to rest of our codebase, so I left some recommended comments for the code. In addition, support of the new anonymous function short hand was introduced in purrr 1.0.0, so can you add a change to the DESCRIPTION file to include purrr (>= 1.0.0) ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an R 4.1 addition, rather than purrr 🐱

Copy link
Collaborator

@zdz2101 zdz2101 Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a modification to Depends: R (>= 4.1) is necessary instead! I retract the purrr statement

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, I would just update the line to

map(set_names(hms), function(y) map_dbl(dtm, function(x) exec(y, x)))

so we don't make an R version dependency for something that is not needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zdz2101 @ddsjoberg for the review. I removed the anonymous function shorthand and added the suggested comments.

@ahasoplakus ahasoplakus removed their assignment Nov 3, 2023
@bms63
Copy link
Collaborator

bms63 commented Nov 3, 2023

@ahasoplakus Please just update the News.md and this looks ready to go to me.

@ahasoplakus
Copy link
Collaborator Author

ahasoplakus commented Nov 3, 2023

@ahasoplakus Please just update the News.md and this looks ready to go to me.

Thanks @bms63! Updated.

@bms63 bms63 merged commit 89a26ab into main Nov 6, 2023
21 checks passed
@bms63 bms63 deleted the 2146_compute_tmf_bug branch November 6, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Time imputation flag incorrect
5 participants