Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devel with Admiral v0.11.1 (#1997) patch #1998

Closed
wants to merge 1 commit into from
Closed

Update devel with Admiral v0.11.1 (#1997) patch #1998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: admiral
Type: Package
Title: ADaM in R Asset Library
Version: 0.11.0
Version: 0.11.1
Authors@R: c(
person("Ben", "Straub", email = "ben.x.straub@gsk.com", role = c("aut", "cre")),
person("Stefan", "Bundfuss", role = "aut"),
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# admiral 0.11.1

- Fix bug in `derive_param_tte()`. (#1962)
- Get Started page now points to correct article. (#1969)

# admiral 0.11.0

## New Features
Expand Down
9 changes: 1 addition & 8 deletions R/derive_param_tte.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,14 +738,7 @@ extend_source_datasets <- function(source_datasets,
by_groups <- unique(bind_rows(by_groups))
for (i in seq_along(source_datasets)) {
if (extend[[i]]) {
source_datasets[[i]] <-
full_join(
mutate(by_groups, temp_dummy = 1),
mutate(source_datasets[[i]], temp_dummy = 1),
by = "temp_dummy",
relationship = "many-to-many"
) %>%
select(-temp_dummy)
source_datasets[[i]] <- crossing(by_groups, source_datasets[[i]])
}
}
source_datasets
Expand Down
22 changes: 11 additions & 11 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,17 @@ remotes::install_github("pharmaverse/admiral", ref = "devel")
The `admiral` family has several downstream and upstream dependencies and so this release shall be done in three
Phases:

* Phase 1 release is for `{admiraldev}`, `{admiral.test}`, and `{admiral}` core
* Phase 1 release is for `{admiraldev}`, `{admiral.test}`, and `{admiral}` core
* Phase 2 release is extension packages, e.g. `{admiralonco}`, `admiralophtha`

|Release Schedule | Phase 1- Date and Packages | Phase 2- Date and Packages |
|---------------- | -------------------------- | -------------------------- |
| Q3-2023 | September 4th | September 11th |
| | `{admiraldev}` `{admiral.test}` | `{admiralonco}` |
| | `{admiral}` | `{admiralophtha}` |
| Q4-2023 | December 4th | December 11th |
| | `{admiraldev}` `{admiral.test}` | `{admiralonco}` |
| | `{admiral}` | `{admiralophtha}` |
| Release Schedule | Phase 1- Date and Packages | Phase 2- Date and Packages |
| ---------------- | ------------------------------- | -------------------------- |
| Q3-2023 | September 4th | September 11th |
| | `{admiraldev}` `{admiral.test}` | `{admiralonco}` |
| | `{admiral}` | `{admiralophtha}` |
| Q4-2023 | December 4th | December 11th |
| | `{admiraldev}` `{admiral.test}` | `{admiralonco}` |
| | `{admiral}` | `{admiralophtha}` |

## Main Goal

Expand Down Expand Up @@ -171,8 +171,8 @@ that all our developers and contributors must follow, so that all our code has a
* [Paving the way for clinical submissions in R](https://phuse.s3.eu-central-1.amazonaws.com/Archive/2023/SDE/EU/London/PRE_London09.pdf) (slides from PHUSE SDE in London)
* [An Overview of {admiral}](https://phuse.s3.eu-central-1.amazonaws.com/Archive/2023/SDE/US/Summit/PRE_Summit03.pdf) (slides from PHUSE SDE in Summit, NJ)
* [{admiralonco}](https://phuse.s3.eu-central-1.amazonaws.com/Archive/2023/Connect/US/Florida/REC_OS12.mp4) (recording for talk at PHUSE US Connect 2023, slides also available [here](https://phuse.s3.eu-central-1.amazonaws.com/Archive/2023/Connect/US/Florida/PRE_OS12.pdf))
* [Programming ADNCA using R and {admiral}](https://phuse.s3.eu-central-1.amazonaws.com/Archive/2023/Connect/US/Florida/REC_OS09.mp4) (recording of presentation from PHUSE US Connect 2023)
* [Clinical Reporting in R](https://www.youtube.com/watch?v=9eod8MLF5ys&list=PLMtxz1fUYA5AWYQHB5mZAs-yamNJ5Tm_8&index=2) (recording of workshop at R in Pharma 2022)
* [Programming ADNCA using R and {admiral}](https://phuse.s3.eu-central-1.amazonaws.com/Archive/2023/Connect/US/Florida/REC_OS09.mp4) (recording of presentation from PHUSE US Connect 2023)
* [Clinical Reporting in R](https://www.youtube.com/watch?v=9eod8MLF5ys\&list=PLMtxz1fUYA5AWYQHB5mZAs-yamNJ5Tm_8\&index=2) (recording of workshop at R in Pharma 2022)
* [Introducing {admiral}](https://www.youtube.com/watch?v=N7Bw8c3D5fU) (recording of talk for R in Pharma 2021)
* [Pharmaverse workshop](https://github.com/pharmaverse/pharmaverse.workshop.phuseUS2022) (slides and materials from PHUSE US Connect 2022---including `{admiral}`
workshop slides from PHUSE EU Connect 2021)
Expand Down
1 change: 1 addition & 0 deletions _pkgdown.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ navbar:
text: User Guides
menu:
- text: Getting Started
href: articles/admiral.html
- text: Creating a Basic ADSL
href: articles/adsl.html
- text: FAQ
Expand Down