Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove styler from DESCRIPTION #1936

Closed
wants to merge 2 commits into from
Closed

Remove styler from DESCRIPTION #1936

wants to merge 2 commits into from

Conversation

galachad
Copy link
Member

@galachad galachad commented Jun 5, 2023

This is pr to remove styler from DESCRRIPTION as it's only used by developer to style the files.

It's need to be cover in other admiral packages like admiraldev, admiraltemplate ...

Linking to #1919

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@galachad
Copy link
Member Author

galachad commented Jun 5, 2023

We can remove the styler from DESCRIPTION

@galachad galachad marked this pull request as ready for review June 5, 2023 13:18
@bms63
Copy link
Collaborator

bms63 commented Jun 5, 2023

Is there a tweak to code needed to fix these failing actions?

@bundfussr
Copy link
Collaborator

Is there a tweak to code needed to fix these failing actions?

I think we need to rename the branch to 1919_remove_styler@devel.

@galachad galachad closed this Jun 6, 2023
@galachad galachad deleted the 1919_remove_styler branch June 6, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants