-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Issue: derive_vars_transposed()
shouldn't produce list columns
#2563
Labels
Comments
bundfussr
moved this from Backlog
to In Progress
in admiral (sdtm/adam, dev, ci, template, core)
Dec 2, 2024
bundfussr
added a commit
that referenced
this issue
Dec 2, 2024
15 tasks
bundfussr
added a commit
that referenced
this issue
Dec 2, 2024
bundfussr
added a commit
that referenced
this issue
Dec 2, 2024
bundfussr
added a commit
that referenced
this issue
Dec 2, 2024
bundfussr
moved this from In Progress
to In Review
in admiral (sdtm/adam, dev, ci, template, core)
Dec 2, 2024
bundfussr
added a commit
that referenced
this issue
Dec 12, 2024
bundfussr
added a commit
that referenced
this issue
Dec 13, 2024
bundfussr
added a commit
that referenced
this issue
Dec 13, 2024
github-project-automation
bot
moved this from In Review
to Archive
in admiral (sdtm/adam, dev, ci, template, core)
Dec 13, 2024
The check on duplicates should be performed after applying the filter. |
github-project-automation
bot
moved this from Archive
to Priority
in admiral (sdtm/adam, dev, ci, template, core)
Dec 16, 2024
bundfussr
moved this from Priority
to In Progress
in admiral (sdtm/adam, dev, ci, template, core)
Dec 16, 2024
bundfussr
added a commit
that referenced
this issue
Dec 16, 2024
15 tasks
bundfussr
moved this from In Progress
to In Review
in admiral (sdtm/adam, dev, ci, template, core)
Dec 16, 2024
bundfussr
added a commit
that referenced
this issue
Dec 17, 2024
* #2563 no_list_columns: add check to avoid list columns * #2563 no_list_columns: update documentation * #2563 no_list_columns: fix example and add see also * #2563 no_list_columns: avoid package name prefix * #2563 no_list_columns: update required admiraldev version * #2563 no_list_columns: split files (and clean up tests) * #2563 no_list_columns: update man * #2563 no_list_columns: filter before check --------- Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
github-project-automation
bot
moved this from In Review
to Archive
in admiral (sdtm/adam, dev, ci, template, core)
Dec 17, 2024
I missed to add a snapshot. |
github-project-automation
bot
moved this from Archive
to Priority
in admiral (sdtm/adam, dev, ci, template, core)
Jan 7, 2025
bundfussr
added a commit
that referenced
this issue
Jan 7, 2025
15 tasks
bms63
pushed a commit
that referenced
this issue
Jan 7, 2025
github-project-automation
bot
moved this from Priority
to Archive
in admiral (sdtm/adam, dev, ci, template, core)
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background Information
The functions
derive_vars_transposed()
andderive_vars_atc()
may produce list columns.Consider for example the ATC variables derivation in the OCCDS vignette:
The issue is that
id_vars = exprs(FAGRPID)
is missing in the call.However, this is not clear from the warning. Furthermore, admiral functions shouldn't produce list columns.
Thus, the uniqueness should be checked in
derive_vars_transposed()
such that an error is issued if the input results in list columns.Definition of Done
An error is issued if the input of
derive_vars_transposed()
results in list columns.The text was updated successfully, but these errors were encountered: