Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Implement derive_vars_extreme_event() #2138

Closed
bundfussr opened this issue Sep 28, 2023 · 1 comment · Fixed by #2236 or #2281
Closed

Feature Request: Implement derive_vars_extreme_event() #2138

bundfussr opened this issue Sep 28, 2023 · 1 comment · Fixed by #2236 or #2281
Assignees
@jeffreyad
Labels
enhancement New feature or request function re-work issues identified by function re-work gang - usually argument alignment, user friendliness programming

Comments

@bundfussr
Copy link
Collaborator

bundfussr commented Sep 28, 2023 •
edited
Loading

Feature Idea

derive_vars_extreme_event(
  dataset,
  by_vars,
  order,
  mode,
  events, # expects a list of event() or event_joined() objects
  source_datasets,
  missing_values = NULL,
  tmp_event_nr_var = NULL, # the variable can be used in order
  check_type = "warning"
)

The function should work like derive_extreme_event() except that the variables defined in the set_values_to field of event() or event_joined() are added to the input dataset.

derive_var_dthcause(), derive_var_extreme_dt(), and derive_var_extreme_dtm() should be superseded.

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response
@bundfussr bundfussr added enhancement New feature or request programming function re-work issues identified by function re-work gang - usually argument alignment, user friendliness future Issue to be implemented after release labels Sep 28, 2023
@bundfussr bundfussr mentioned this issue Oct 9, 2023
Closed
@jeffreyad jeffreyad self-assigned this Oct 23, 2023
@bms63 bms63 moved this from Backlog to Priority in admiral (sdtm/adam, dev, ci, template, core) Nov 1, 2023
jeffreyad added a commit that referenced this issue Nov 15, 2023
@jeffreyad
Chore #2138 Implement derive_vars_extreme_event()
60a0cba
@jeffreyad jeffreyad linked a pull request Nov 15, 2023 that will close this issue
Closes #2138 Implement derive_vars_extreme_event() #2236
Merged
14 tasks
jeffreyad added a commit that referenced this issue Nov 16, 2023
@jeffreyad
#2138 run styler
d670044
jeffreyad added a commit that referenced this issue Nov 16, 2023
@jeffreyad
#2138 update documentation after styler and edit for derive_extreme().
f967254
jeffreyad added a commit that referenced this issue Nov 16, 2023
@jeffreyad
#2138 add lb data to derive_vars_extreme_event() example
8e514c3
jeffreyad added a commit that referenced this issue Nov 20, 2023
@jeffreyad
#2138 Update test coverage for event$order
dee0f83
jeffreyad added a commit that referenced this issue Nov 20, 2023
@jeffreyad
#2138 Run styler on test file
34ad1a3
jeffreyad added a commit that referenced this issue Nov 21, 2023
@jeffreyad
#2138 minor updates to documentation
d54f7ed
@bms63 bms63 moved this from Priority to In Progress in admiral (sdtm/adam, dev, ci, template, core) Nov 21, 2023
@bms63 bms63 moved this from In Progress to In Review in admiral (sdtm/adam, dev, ci, template, core) Nov 21, 2023
jeffreyad added a commit that referenced this issue Nov 21, 2023
@jeffreyad
#2138 remove derive_extreme() function. Call derive_extreme_event() i…
5757799 
…n derive_vars_extreme_event()
jeffreyad added a commit that referenced this issue Nov 21, 2023
@jeffreyad
#2138 run styler
36646f9
jeffreyad added a commit that referenced this issue Nov 21, 2023
@jeffreyad
#2138 Add DTHCAUS example
dbf4094
@bundfussr bundfussr mentioned this issue Nov 22, 2023
Merged
14 tasks
jeffreyad added a commit that referenced this issue Nov 23, 2023
@jeffreyad
#2138 updates from feedback
07a3c39
jeffreyad added a commit that referenced this issue Nov 23, 2023
@jeffreyad
#2138 update example code
fb8f45a
jeffreyad added a commit that referenced this issue Nov 27, 2023
@jeffreyad
#2138 Update to set_values_to
c79eff2
jeffreyad added a commit that referenced this issue Nov 27, 2023
@jeffreyad
#2138 update LSTALVDT in ADSL template and vignette
e488508
jeffreyad added a commit that referenced this issue Nov 27, 2023
@jeffreyad
#2138 Update DTHCAUS in ADSL vignette
67aae52
jeffreyad added a commit that referenced this issue Nov 28, 2023
@jeffreyad
#2138 simplify new_vars call in ADSL
802a6af
jeffreyad added a commit that referenced this issue Nov 28, 2023
@jeffreyad
#2138 Simplify new_vars in example
e3c9543
jeffreyad added a commit that referenced this issue Nov 28, 2023
@jeffreyad
#2138 Simplify new_vars in example
384b686
jeffreyad added a commit that referenced this issue Nov 28, 2023
@jeffreyad
#2138 doc updates
dbac2db
jeffreyad added a commit that referenced this issue Nov 28, 2023
@jeffreyad
#2138 Split files
0e0df93
jeffreyad added a commit that referenced this issue Nov 28, 2023
@jeffreyad
#2138 run styler on new test files
fce2932
jeffreyad added a commit that referenced this issue Nov 29, 2023
@jeffreyad
#2138 set_values_to default NULL
9cfe58f
jeffreyad added a commit that referenced this issue Nov 29, 2023
@jeffreyad
#2138 set_values_to default NULL
5b3c9e1
jeffreyad added a commit that referenced this issue Nov 29, 2023
@jeffreyad
#2138 doc: filter to filter_join argument
fe12854
jeffreyad added a commit that referenced this issue Nov 29, 2023
@jeffreyad
#2138 remove set_values_to call from derive_vars_extreme_event()
6554b90
@bms63 bms63 removed the future Issue to be implemented after release label Nov 29, 2023
bms63 pushed a commit that referenced this issue Nov 29, 2023
@jeffreyad
Closes #2138 Implement derive_vars_extreme_event() (#2236)
c126ac2 
* Chore #2138 Implement derive_vars_extreme_event()

* #2138 run styler

* #2138 update documentation after styler and edit for derive_extreme().

* #2138 add lb data to derive_vars_extreme_event() example

* #2138 Update test coverage for event$order

* #2138 Run styler on test file

* #2138 minor updates to documentation

* #2138 remove derive_extreme() function.  Call derive_extreme_event() in derive_vars_extreme_event()

* #2138 run styler

* #2138 Add DTHCAUS example

* #2138 updates from feedback

* #2138 update example code

* #2138 Update to set_values_to

* #2138 update LSTALVDT in ADSL template and vignette

* #2138 Update DTHCAUS in ADSL vignette

* #2138 simplify new_vars call in ADSL

* #2138 Simplify new_vars in example

* #2138 Simplify new_vars in example

* #2138 doc updates

* #2138 Split files

* #2138 run styler on new test files

* #2138 set_values_to default NULL

* #2138 set_values_to default NULL

* #2138 doc: filter to filter_join argument

* #2138 remove set_values_to call from derive_vars_extreme_event()

---------

Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com>
@bundfussr
Copy link
Collaborator Author

The by_vars argument should not have a default value because it is mandatory.

@bundfussr bundfussr reopened this Dec 6, 2023
jeffreyad added a commit that referenced this issue Dec 6, 2023
@jeffreyad
#2138 remove by_vars default
4e9a96c
@jeffreyad jeffreyad linked a pull request Dec 6, 2023 that will close this issue
Closes #2138 remove by_vars default #2281
Merged
15 tasks
bms63 pushed a commit that referenced this issue Dec 6, 2023
@jeffreyad
Closes #2138 remove by_vars default (#2281)
78429d5 
#2138 remove by_vars default

Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffreyad jeffreyad

Labels
enhancement New feature or request function re-work issues identified by function re-work gang - usually argument alignment, user friendliness programming
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
3 participants
@bms63 @bundfussr @jeffreyad