Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False failure on macOS 12 due to fortran redirect bug #14

Closed
conradtchan opened this issue Feb 17, 2022 · 0 comments · Fixed by #15
Closed

False failure on macOS 12 due to fortran redirect bug #14

conradtchan opened this issue Feb 17, 2022 · 0 comments · Fixed by #15

Comments

@conradtchan
Copy link
Contributor

In run-benchmarks.sh:

./diffdumps ${reffile/.ref/} ${reffile} $tol > $difflog

writes an empty file, regardless of the result. This is a known bug with macOS 12 + gfortran: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102992

Because the file is empty, the script cannot find the string "FILES ARE IDENTICAL" and incorrectly reports that the results differ.
This was referenced Feb 17, 2022
Merged
Merged
conradtchan added a commit to danieljprice/phantom that referenced this issue Feb 17, 2022
@conradtchan
diffdumps: return a non-zero exit code if files differ (#237)
499de83 
Type of PR:
modification to existing code

Description:
Return a non-zero exit code from diffdumps when the files differ.

This change is needed to resolve (along with phantomSPH/phantom-benchmarks#15) phantomSPH/phantom-benchmarks#14

Testing:
Benchmark tests: ./run-benchmarks.sh

Did you run the bots? yes, pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mac redirect ADACS-Australia/phantom-benchmarks
1 participant
@conradtchan