Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added cli/launcher.bat and add changelog #1440 #1441

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

jenovateurs
Copy link
Contributor

Hello team!
I added the launcher.bat file that missing for Windows.
I changed / to DIRECTORY_SEPARATOR.
In the launcher.bat files, I changed the name PATH to CURRENT_PATH. Windows use PATH to know where php is locate so it's very important to not override this variable.
I added a changelog, it will be useful when release a new version.

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Thanks for the review :-)

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #1441 into 4.0.x will increase coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             4.0.x   #1441      +/-   ##
==========================================
+ Coverage     3.55%   3.67%   +0.12%     
  Complexity    1099    1099              
==========================================
  Files          111     111              
  Lines         4756    4762       +6     
==========================================
+ Hits           169     175       +6     
  Misses        4587    4587
Impacted Files Coverage Δ Complexity Δ
src/Builder/Project/Cli.php 0% <0%> (ø) 7 <0> (ø) ⬇️
src/Script/Color.php 35.89% <0%> (+15.38%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e8e99...b9a6ec2. Read the comment docs.

@jenovateurs
Copy link
Contributor Author

Thanks @Jeckerson and @sergeyklay for your reviews :-).

@jenovateurs jenovateurs merged commit 0d2dfb2 into phalcon:4.0.x Apr 2, 2020
@jenovateurs jenovateurs added the CLI label Apr 2, 2020
@jenovateurs jenovateurs linked an issue Apr 2, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fatal Error - Creating cli project with Windows
3 participants