Fixed Incorrect DocBlock for Collection::count() #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninjapanzer
reviewed
Sep 10, 2017
src/Phalcon/mvc/Collection.php
Outdated
| @@ -614,7 +614,7 @@ public static function count(array $parameters = null) {} | |||
| * Perform an aggregation using the Mongo aggregation framework | |||
| * | |||
| * @param array $parameters | |||
| * @return array | |||
| * @return int | |||
There was a problem hiding this comment.
did you mean to make this change around aggregate instead of count? I think this should be on line :609
ninjapanzer
approved these changes
Sep 10, 2017
|
Thank You! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phalcon/cphalcon#13063 was opened. I assume the stubs are generated by looking at zephir. Thus, no need to merge this. However, I am adding this here for historical purposes.