Create table, schema reference fix #3213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made getBestLanguage to return family language by default. I believe most of the developers already manually substr the entry for translation. This should reduce that 1/2 lines
|
you are mixing two fixes (a fix for mysql and a fix for #3135) in the same pull request. You should remove the last two commits from this branch, then create another branch with the fixes for #3135 and make another pull request. Also, this pull request is on master, which is not accepted by phalcon: |
Taking advantage of keep snapshot,
It will attempt to save parent on preSave,
Check itself for changes, if no changes just attempt to save child.
Note. PostSave for the specific model will not be called.
$user = User::findFirst(array("id = 🆔", "bind" => array("id" =>
1)));
$user->save(); <<== not called
$user = User::findFirst(array("id = 🆔", "bind" => array("id" =>
2)));
$user->primary_email = "test@test.com";
$av = new AccountVerify();
$av->key = "asdasdsad"; // processed as child
$user->accountverify = $av;
$user->save(); <<== called
$user = User::findFirst(array("id = 🆔", "bind" => array("id" =>
3)));
$user->save(); //not called
|
I aint good with this git, been sometime since i used it. confusing as shit. i am trying to reconcile all changes back to 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.