Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T14764 gettext setlocale #15395

Closed
wants to merge 18 commits into from
Closed

T14764 gettext setlocale #15395

wants to merge 18 commits into from

Conversation

niden
Copy link
Member

@niden niden commented Apr 12, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed the signature of setLocale in Translate\Adapter\Gettext to allow multiple locale declarations if necessary. Aligns with setlocale

Thanks

@niden niden self-assigned this Apr 12, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low labels Apr 12, 2021
@niden niden linked an issue Apr 12, 2021 that may be closed by this pull request
[BUG]: Phalcon\Translate\Adapter\Gettext:setLocale doesn't allow multiple locales #14764
Closed
niden added 16 commits April 22, 2021 18:38
@niden
refactor(translate/gettext): changed the signature of setLocale to us…
b2e28a1 
…e an array as the second parameter

[#14764]
@niden
fix(translate/gettext): changed setLocale signature to allow the cate…
063a7ac 
…gory and an array of locales

the method signature abides with the setlocale method

[#14764]
@niden
build(docker): reorganized docker files; added gettext
66854e6
@niden
build(github/actions): enabling different locales
744188f
@niden
build(github/actions): trying a different format for enabling locales
e9af0ee
@niden
fix(translate/adapter/gettext): correcting locale setup for tests
b37b76f 
[#14764]
@niden
fix(translate/adapter/gettext): adjusting test for setLocale/load fac…
e33379a 
…tory

[#14764]
@niden
fix(translate/adapter/gettext): updated changelog
ab7bce1 
[#14764]
@niden
fix(translate/adapter/gettext): updating the build to enable locales
def8516 
[#14764]
@niden
build(github/actions): adding locale setup in codecoverage
3115ab3
@niden
build(github/actions): trying locales for macos - I have no idea if t…
8d3a47c 
…his will worky
@niden
build(github/actions): removed apt-get command from macos section
beff768
@niden
build(macos): trying to figure out how locales are set
5b6f47f
@niden
build(macos): exporting locale variables
c0a219d
@niden
build(actions): trying a different osx config for locales
bffcfc4 
Refs [#14764]
@niden
build(actions): trying different syntax for localedef
c70b57f 
Refs [#14764]
Jeckerson
Jeckerson reviewed Apr 22, 2021
View reviewed changes
docker/8.0/Dockerfile Outdated Show resolved Hide resolved
@niden niden closed this May 3, 2021
@niden niden deleted the T14764-gettext-setlocale branch November 1, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson left review comments

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Phalcon\Translate\Adapter\Gettext:setLocale doesn't allow multiple locales
2 participants
@niden @Jeckerson