Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct database tests #15003

Merged
merged 2 commits into from
May 4, 2020
Merged

Correct database tests #15003

merged 2 commits into from
May 4, 2020

Conversation

sergeyklay
Copy link
Contributor

Hello!

  • Type: bug fix | code quality | documentation
  • Link to issue: -

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

  • Correct database tests
  • Update documentation
  • Code cleanup

Thanks

@sergeyklay sergeyklay added testing Tests related issue 4.0.6 labels May 4, 2020
@sergeyklay sergeyklay self-assigned this May 4, 2020
@sergeyklay
Copy link
Contributor Author

All tests are passed. The failed one on macOS is not related. Possible the same as in #14981

@sergeyklay sergeyklay merged commit 930fc08 into 4.0.x May 4, 2020
@sergeyklay sergeyklay deleted the fix/correct-database-tests branch May 4, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sergeyklay sergeyklay

Labels
testing Tests related issue
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sergeyklay