Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed return type hint for Phalcon\Mvc\Model::sum #15001

Merged
merged 3 commits into from
May 4, 2020
Merged

Fixed return type hint for Phalcon\Mvc\Model::sum #15001

merged 3 commits into from
May 4, 2020

Conversation

sergeyklay
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

  • Changed return type hint for Phalcon\Mvc\ModelInterface::sum
  • Fixed return type hint for Phalcon\Mvc\Model::sum

Thanks

@sergeyklay sergeyklay self-assigned this May 4, 2020
@sergeyklay sergeyklay linked an issue May 4, 2020 that may be closed by this pull request
[BUG]: Wrong return type hint for Phalcon\Mvc\Model::sum #15000
Closed
@sergeyklay sergeyklay merged commit abb5d64 into 4.0.x May 4, 2020
@sergeyklay sergeyklay deleted the fix/model-sum-return-type-hint branch May 4, 2020 09:47
@sergeyklay sergeyklay added the bug A bug report label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sergeyklay sergeyklay

Labels
bug A bug report status: low Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Wrong return type hint for Phalcon\Mvc\Model::sum
1 participant
@sergeyklay