Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect Phalcon\Factory\ValidatorInterface #14749

Merged
merged 3 commits into from
Jan 22, 2020
Merged

Fixed incorrect Phalcon\Factory\ValidatorInterface #14749

merged 3 commits into from
Jan 22, 2020

Conversation

ruudboon
Copy link
Member

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
Fixed issue with non existing interface used

niden
niden previously approved these changes Jan 21, 2020
@niden niden added 4.0.3 enhancement Enhancement to the framework labels Jan 21, 2020
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #14749 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14749      +/-   ##
==========================================
+ Coverage   67.97%   67.98%   +<.01%     
==========================================
  Files         483      483              
  Lines      111435   111435              
==========================================
+ Hits        75752    75758       +6     
+ Misses      35683    35677       -6

@niden niden merged commit e9b31fc into phalcon:4.0.x Jan 22, 2020
@ruudboon ruudboon deleted the stubs-errors branch February 4, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants