Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T3135 best language #14698

Merged
merged 9 commits into from
Jan 11, 2020
Merged

T3135 best language #14698

merged 9 commits into from
Jan 11, 2020

Conversation

niden
Copy link
Member

@niden niden commented Jan 11, 2020

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Added Phalcon\Http\Request::getBestLanguageIso() to return the base language if this is a specific one (en vs en-US)

Thanks

@niden niden self-assigned this Jan 11, 2020
@niden niden added 4.1.0 documentation Documentation required new feature request Planned Feature or New Feature Request labels Jan 11, 2020
@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #14698 into 4.1.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.1.x   #14698      +/-   ##
==========================================
+ Coverage   67.75%   67.76%   +<.01%     
==========================================
  Files         480      480              
  Lines      111629   111654      +25     
==========================================
+ Hits        75637    75662      +25     
  Misses      35992    35992

phalcon/Http/Request.zep Show resolved Hide resolved
@niden niden merged commit 318a19d into phalcon:4.1.x Jan 11, 2020
@niden niden deleted the T3135-best-language branch January 11, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation required new feature request Planned Feature or New Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants