Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 14691 #14692

Merged
merged 7 commits into from
Jan 9, 2020
Merged

Issue 14691 #14692

merged 7 commits into from
Jan 9, 2020

Conversation

ruudboon
Copy link
Member

@ruudboon ruudboon commented Jan 9, 2020

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
Fixed ENUM detection on MySQL when using an option that matches a column name like internal

@ruudboon ruudboon added the 4.0.1 label Jan 9, 2020
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #14692 into 4.0.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            4.0.x   #14692   +/-   ##
=======================================
  Coverage   67.96%   67.96%           
=======================================
  Files         483      483           
  Lines      111483   111483           
=======================================
  Hits        75774    75774           
  Misses      35709    35709

@niden niden added bug A bug report status: low Low labels Jan 9, 2020
@ruudboon ruudboon merged commit 003f3d4 into phalcon:4.0.x Jan 9, 2020
@ruudboon ruudboon deleted the issue-14691 branch January 9, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants