[#14485] ignore_unknown_columns global is respected by update and insert #14486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudboon
approved these changes
Oct 25, 2019
niden
approved these changes
Oct 25, 2019
Codecov Report
@@ Coverage Diff @@
## 4.0.x #14486 +/- ##
==========================================
- Coverage 67.71% 67.7% -0.01%
==========================================
Files 482 482
Lines 111380 111384 +4
==========================================
Hits 75416 75416
- Misses 35964 35968 +4 |
|
Thanks @CameronHall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change: Fixed an issue with updating and inserting data into tables with unmapped columns when
phalcon.orm.ignore_unknown_columnsis set totrue.Thanks