Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json serializable paginator repository #14475

Merged
merged 3 commits into from
Oct 17, 2019
Merged

Json serializable paginator repository #14475

merged 3 commits into from
Oct 17, 2019

Conversation

ekmst
Copy link
Contributor

@ekmst ekmst commented Oct 16, 2019 •
edited
Loading

Hello!

  • Type: new feature
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
Phalcon\Paginator\Repository implementing JsonSerializable

Thanks

@ekmst ekmst force-pushed the jsonSerializable-paginator branch from 618c4e0 to 6096a85 Compare October 16, 2019 10:35
@codecov
Copy link

codecov bot commented Oct 16, 2019 •
edited
Loading

Codecov Report

Merging #14475 into 4.0.x will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14475      +/-   ##
==========================================
- Coverage   67.67%   67.57%   -0.11%     
==========================================
  Files         482      482              
  Lines      111321   111354      +33     
==========================================
- Hits        75335    75244      -91     
- Misses      35986    36110     +124

@niden niden merged commit e096246 into phalcon:4.0.x Oct 17, 2019
@niden
Copy link
Member

niden commented Oct 17, 2019

Thank you @ekmst

@niden niden added 4.0 enhancement Enhancement to the framework labels Oct 17, 2019
@ekmst ekmst deleted the jsonSerializable-paginator branch October 17, 2019 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekmst @niden