-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model::__callStatic() enhancements #14467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the called method is unknown.
`0` and `null` as parameter.
Magic methods using These function calls are now valid: Robots::findByField(null);
Robots::findByField("");
Robots::findByField(0);
Robots::findFirstByField(null);
Robots::findFirstByField("");
Robots::findFirstByField(0);
Robots::countByField(null);
Robots::countByField("");
Robots::countByField(0); |
Codecov Report
@@ Coverage Diff @@
## 4.0.x #14467 +/- ##
==========================================
+ Coverage 67.67% 67.69% +0.02%
==========================================
Files 482 482
Lines 111331 111360 +29
==========================================
+ Hits 75339 75390 +51
+ Misses 35992 35970 -22 |
zsilbi
changed the title
Changed Model::__callStatic() to throw an exception for unknown calls
Model::__callStatic() enhancements
Oct 14, 2019
sergeyklay
previously approved these changes
Oct 14, 2019
niden
approved these changes
Oct 14, 2019
Thank you @zsilbi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Phalcon\Mvc\Model::__callStatic()
now throws an exception if the called method is unknown.Added tests for
Phalcon\Mvc\Model::__callStatic()
.Thanks,
zsilbi