Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form attributes fixed #14421

Merged
merged 3 commits into from
Sep 26, 2019
Merged

Form attributes fixed #14421

merged 3 commits into from
Sep 26, 2019

Conversation

zsilbi
Copy link
Member

@zsilbi zsilbi commented Sep 26, 2019

Hello!

  • Type: bug fix

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Form::setAction() fails when called in Form::initialize() because the default attributes are only set, after the initialize() had finished.

Thanks,
zsilbi

@zsilbi zsilbi changed the title Form set Form attributes fixed Sep 26, 2019
@niden niden added 4.0 labels Sep 26, 2019
@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #14421 into 4.0.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            4.0.x   #14421   +/-   ##
=======================================
  Coverage   67.63%   67.63%           
=======================================
  Files         478      478           
  Lines      110895   110895           
=======================================
  Hits        75005    75005           
  Misses      35890    35890

@ruudboon ruudboon merged commit ec1ff70 into phalcon:4.0.x Sep 26, 2019
@zsilbi zsilbi deleted the form-attributes-fix branch September 26, 2019 13:57
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants