Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create instance #14419

Merged
merged 7 commits into from
Sep 26, 2019
Merged

Create instance #14419

merged 7 commits into from
Sep 26, 2019

Conversation

niden
Copy link
Member

@niden niden commented Sep 25, 2019

Hello!

  • Type: performance
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed all calls to new <object> to use the create_instance or create_instance_params for better performance.

Thanks

@niden niden added 4.0 enhancement Enhancement to the framework labels Sep 25, 2019
@niden
Copy link
Member Author

niden commented Sep 25, 2019

cc @sergeyklay @ruudboon

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #14419 into 4.0.x will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14419      +/-   ##
==========================================
+ Coverage   67.63%   67.64%   +0.01%     
==========================================
  Files         478      478              
  Lines      110895   110919      +24     
==========================================
+ Hits        75005    75036      +31     
+ Misses      35890    35883       -7

build/README.md Outdated Show resolved Hide resolved
sergeyklay
sergeyklay previously approved these changes Sep 26, 2019
phalcon/Mvc/Model.zep Outdated Show resolved Hide resolved
@niden niden merged commit c58d09e into phalcon:4.0.x Sep 26, 2019
@niden niden deleted the create-instance branch September 26, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants