Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style fixes (code quality) #14407

Merged
merged 15 commits into from
Sep 24, 2019
Merged

Style fixes (code quality) #14407

merged 15 commits into from
Sep 24, 2019
+23 −33

Conversation

ruudboon
Copy link
Member

@ruudboon ruudboon commented Sep 23, 2019 •
edited
Loading

Hello!

  • Type: code quality
    Some styling fixes and interface mismatch fixes
  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

--

  • Removed double use use Phalcon\Events\ManagerInterface as EventsManagerInterface
  • Interfaces cannot have final
  • Typo in inline class
  • Interface corrections for handle()
  • Styling fix

sergeyklay
sergeyklay reviewed Sep 23, 2019
View reviewed changes
phalcon/Cli/Console.zep Outdated Show resolved Hide resolved
sergeyklay
sergeyklay reviewed Sep 23, 2019
View reviewed changes
phalcon/Cli/Console.zep Outdated Show resolved Hide resolved
@ruudboon ruudboon changed the title Style fixes (code quality) [WIP] Style fixes (code quality) Sep 23, 2019
@codecov
Copy link

codecov bot commented Sep 24, 2019 •
edited
Loading

Codecov Report

Merging #14407 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14407      +/-   ##
==========================================
+ Coverage   67.64%   67.64%   +<.01%     
==========================================
  Files         478      478              
  Lines      110971   110970       -1     
==========================================
  Hits        75061    75061              
+ Misses      35910    35909       -1

niden
niden reviewed Sep 24, 2019
View reviewed changes
phalcon/Application/AbstractApplication.zep Outdated Show resolved Hide resolved
phalcon/Cli/Console.zep Outdated Show resolved Hide resolved
phalcon/Mvc/Application.zep Outdated Show resolved Hide resolved
@niden
Copy link
Member

niden commented Sep 24, 2019

@ruudboon Some comments above that would most likely solve this.

@ruudboon
- Removed handle from AbstractApplication
4d6b0a8 
- Reverted changes on Phalcon\Cli\Console & Phalcon\Mvc\Application:handle()
Jeckerson
Jeckerson previously approved these changes Sep 24, 2019
View reviewed changes
sergeyklay
sergeyklay previously approved these changes Sep 24, 2019
View reviewed changes
@ruudboon ruudboon dismissed stale reviews from sergeyklay and Jeckerson via ea8cdce September 24, 2019 09:37
@ruudboon ruudboon changed the title [WIP] Style fixes (code quality) Style fixes (code quality) Sep 24, 2019
@ruudboon ruudboon requested a review from sergeyklay September 24, 2019 09:39
@ruudboon ruudboon requested a review from niden September 24, 2019 13:14
@ruudboon ruudboon merged commit 5de838f into phalcon:4.0.x Sep 24, 2019
@ruudboon ruudboon deleted the style-fixes branch September 24, 2019 14:48
@niden niden added 4.0 enhancement Enhancement to the framework labels Sep 24, 2019
@ghost ghost mentioned this pull request Oct 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

@Jeckerson Jeckerson Jeckerson left review comments

@sergeyklay sergeyklay Awaiting requested review from sergeyklay

Assignees
No one assigned
Labels
enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruudboon @niden @sergeyklay @Jeckerson