redis adapter update: add persistent id for pconnect() method
#14340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudboon
requested changes
Aug 28, 2019
|
A few small changes and think we're good to go. Thnx |
Codecov Report
@@ Coverage Diff @@
## 4.0.x #14340 +/- ##
==========================================
+ Coverage 66.3% 66.31% +<.01%
==========================================
Files 488 488
Lines 115903 115905 +2
==========================================
+ Hits 76855 76857 +2
Misses 39048 39048 |
ruudboon
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain
Another old pull request #14335 based on a wrong branch, so I close it and open the new one.
sorry, it's my first time to create a pull request.
Description
we'd better have a persistent id for Redis pconnect() method.
cause without it we can't switch between multiple databases at in the same PHP process.
the data will always be saved to the last database without it.
as I know all Phalcon versions have this bug.
Issue