Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 14314 #14315

Merged
merged 4 commits into from
Aug 20, 2019
Merged

Fixed issue 14314 #14315

merged 4 commits into from
Aug 20, 2019

Conversation

ZhangRuiMingZRM
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #14315 into 4.0.x will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14315      +/-   ##
==========================================
+ Coverage   66.18%   66.31%   +0.12%     
==========================================
  Files         488      488              
  Lines      115913   115919       +6     
==========================================
+ Hits        76714    76868     +154     
+ Misses      39199    39051     -148

Mentioned AbstractAdapter in changelog
ruudboon
ruudboon previously approved these changes Aug 20, 2019
@ruudboon ruudboon requested a review from sergeyklay August 20, 2019 07:57
Jeckerson
Jeckerson previously approved these changes Aug 20, 2019
Co-Authored-By: Serghei Iakovlev <sergeyklay@users.noreply.github.com>
@ZhangRuiMingZRM ZhangRuiMingZRM dismissed stale reviews from Jeckerson and ruudboon via d64931a August 20, 2019 14:17
@sergeyklay sergeyklay merged commit e0badaf into phalcon:4.0.x Aug 20, 2019
@sergeyklay
Copy link
Contributor

Thank you

@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants