-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phalcon\Security::computeHmac() plus many bug fixes #1347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phalcon
pushed a commit
that referenced
this pull request
Oct 8, 2013
Phalcon\Security::computeHmac() plus many bug fixes
ghost
deleted the
security
branch
October 9, 2013 07:55
ghost
mentioned this pull request
Oct 9, 2013
phalcon
pushed a commit
that referenced
this pull request
Oct 9, 2013
[1.2.4] Backport bug fixes from #1347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial idea of this PR was to introduce Phalcon\Security\computeHmac() function which computes HMAC of the given message — it can be used to verify both the data integrity and the authentication of a message. One of its possible applications is to verify that the cookies were not tampered with.
Bug fixes included into this PR:
To properly fix #1340 (and similar bugs in the rest of the code) I have made these changes:
PHALCON_SEPARATE_PARAM()
now always separates its parameter — regardless of its refcount;phalcon_fetch_parameters_ex()
function andfetch_params_ex()
macro — these ones returnzval**
instead ofzval*
. However, this allows to useSEPARATE_ZVAL()
on the returned arguments without worrying about memory leaks;PHALCON_ENSURE_IS_xxx()
. These ones takezval**
as their argument, separate it if it is not a reference and perform type conversion. These macros are friendly to memory frames; they can work with method arguments but only if the arguments were fetched withfetch_params_ex()
.